Fix bug in FOU netlink parser #827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin31821 pls squash your commits into one |
|
@martin31821 please squash your commits into one |
This fixes a bug that netlink messages for FOU are not correctly deserialized Fix unused var shift Fix incorrect test case
martin31821
force-pushed
the
fou_netlink_parser_padding
branch
from
b7c69d2
to
1fbb024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlink API states that the TLV tuples should be padded to 4 bytes, which was implemented incorrectly in the FOU case.
On recent kernels, ListFou fails because the kernel returns more attributes than the parser expects.