Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update azure-aci to use nodeutil instead of node-cli #411

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Jan 5, 2023

  • Move away from the node-cli library and use the built-in nodeutil package from virtual-kubelet instead.
  • Use the new virtual-kubelet version, v1.8.0.
  • Upgrade Kubernetes version to v1.26.0
    • Update Liveness/ReadinessProbe (Prope -> PropeHandler)

Fixes: #410, #191

Update the old PR #277

Signed-off-by: Heba Elayoty [email protected]

@helayoty helayoty requested a review from Fei-Guo as a code owner January 5, 2023 01:45
@helayoty helayoty temporarily deployed to test January 5, 2023 01:45 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 5, 2023 01:45 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 5, 2023 02:01 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 5, 2023 02:01 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #411 (77a6af7) into master (0c76852) will increase coverage by 2.32%.
The diff coverage is 47.10%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   42.91%   45.23%   +2.32%     
==========================================
  Files          50       15      -35     
  Lines        5735     2465    -3270     
==========================================
- Hits         2461     1115    -1346     
+ Misses       3017     1265    -1752     
+ Partials      257       85     -172     
Impacted Files Coverage Δ
pkg/featureflag/feature_flag.go 75.00% <ø> (+20.00%) ⬆️
pkg/provider/podsTracker.go 0.00% <0.00%> (ø)
pkg/network/aci_network.go 20.43% <7.74%> (-6.10%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 73.33% <55.00%> (-3.42%) ⬇️
pkg/provider/aci_volumes.go 45.19% <62.50%> (ø)
pkg/provider/aci.go 44.41% <63.20%> (+10.52%) ⬆️
pkg/provider/containergroup_to_pod.go 71.93% <75.80%> (-3.35%) ⬇️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)
pkg/provider/config.go 68.29% <100.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test January 5, 2023 02:36 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 5, 2023 02:36 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 10, 2023 00:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 10, 2023 00:51 — with GitHub Actions Inactive
pkg/provider/aci.go Outdated Show resolved Hide resolved
@helayoty helayoty temporarily deployed to test January 18, 2023 21:20 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 21:20 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 21:27 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 21:29 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 21:37 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 18, 2023 21:38 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 17:39 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 17:40 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 20:20 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 20:20 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 16:28 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 17:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 17:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 17:41 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 17:41 — with GitHub Actions Inactive
pkg/tests/utils.go Show resolved Hide resolved
pkg/provider/podsTracker.go Outdated Show resolved Hide resolved
pkg/provider/aci_volumes_test.go Outdated Show resolved Hide resolved
pkg/provider/aci_test.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
@helayoty helayoty temporarily deployed to test March 16, 2023 21:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:49 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:49 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:55 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 21:55 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 22:40 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 16, 2023 22:40 — with GitHub Actions Inactive
@helayoty helayoty requested a review from Fei-Guo March 16, 2023 22:47
@helayoty helayoty merged commit 3b58bc0 into virtual-kubelet:master Mar 16, 2023
@helayoty helayoty deleted the nodeutil-migration branch March 16, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update azure-aci to use nodeutil instead of node-cli
4 participants