Add composite unique on name and version #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-d-zhang
approved these changes
Jun 27, 2023
| async with session.begin_nested(): | ||
| session.add(row) | ||
| except IntegrityError: | ||
| pass |
There was a problem hiding this comment.
not logging this? or returning errors?
There was a problem hiding this comment.
Didn't figure it was necessary. Attempting to scan duplicate packages is going to be very common - after all the mechanism that's going to be reading from the RSS feed and loading it into the database doesn't do any of the checking. 90-95% of packages batch queued will already be queued for scanning in the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a lot of the previous code that did checking on on the batch queue endpoint for duplicates. The old code was awkward and unwieldy, this is however, much better. It allows us to simply iterate over all the ingested packages, and add them to the database without any extra queries required for checking if they already exist or not.