Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reporting on quarantined packages #322

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow reporting on quarantined packages #322

wants to merge 3 commits into from
+19 −27

Conversation

Robin5605
Copy link
Contributor

Closes #319

@Robin5605
Add httpx client dependency
ba0953d 
Create a dependency to get the HTTPX client. This was always there bound
to state, but wrapping it in a dependency provides a cleaner interface
and better testability.
@Robin5605
Modify reporter to check PyPI package page instead of JSON API
987c7af 
This will ensure that quarantined packages don't register as "not on
PyPI" because quarantined packages are not visible through the JSON API,
however still show as normal when queried through
pypi.org/project/<project_name>.
@Robin5605
Fix tests
b7e2d3c 
Fix tests to have them pass in mock objects as arguments rather than
trying to monkeypatch the httpx module by injecting mocks
@Robin5605 Robin5605 requested review from a team as code owners October 1, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-d-zhang jonathan-d-zhang Awaiting requested review from jonathan-d-zhang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow reporting on quarantined packages
1 participant
@Robin5605