Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus metrics #110

Closed
wants to merge 7 commits into from
Closed

Add Prometheus metrics #110

wants to merge 7 commits into from

Conversation

Robin5605
Copy link
Contributor

@Robin5605 Robin5605 commented Jul 19, 2023

Add a metrics endpoint which can be scraped by Prometheus. The follow metrics can be scraped by Prometheus:

  • Packages ingested (queued) since API startup
  • Total packages scanned sinced API startup (success + failure)
  • Total packages scanned since API startup that were successful
  • Total packages scanned since API startup that failed
  • Total packages reported since API startup
  • Average request time
  • Total number of requests served

AbooMinister25
AbooMinister25 previously approved these changes Jul 20, 2023
Copy link
Contributor

@AbooMinister25 AbooMinister25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM

@Xithrius
Copy link
Member

Xithrius commented Mar 4, 2024

I can continue this PR in a new one with prometheus-fastapi-instrumentator and prometheus-client, and then add Grafana to the infra of this org somewhere. Thoughts @Robin5605?

@Robin5605
Copy link
Contributor Author

@Xithrius sounds great! I'll be closing this issue then as it's stale.

@Robin5605 Robin5605 closed this Mar 6, 2024
@Robin5605 Robin5605 reopened this Apr 11, 2024
@Robin5605 Robin5605 requested review from a team as code owners April 11, 2024 01:48
@Robin5605
Copy link
Contributor Author

Hi @Xithrius , I actually think we can just continue work on this one - I feel like working on this again and will be pushing some commits here shortly. Feel free to also push commits and make changes to this branch if you so please. Just didn't want 2 PRs that did essentially the same thing and we've got stuff to work off here already

@shenanigansd shenanigansd marked this pull request as draft May 30, 2024 01:09
@Robin5605
Copy link
Contributor Author

Closing for now as #257 gives us observability. May open in the future if we want to move away from logfire.

@Robin5605 Robin5605 closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants