Auto-including well-foundedness functions and axioms when they are used #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…disappearing (because sets), fixed typo in multiset well-def domain
|
I'm not sure who to ask to review this. Who's worked on the termination plugin before? @ArquintL maybe? |
ArquintL
reviewed
Jun 15, 2023
src/main/scala/viper/silver/plugin/standard/termination/TerminationPlugin.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Linard Arquint <[email protected]>
…ctly-named domain
…pting autoimport and warning code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of the termination plugin that auto-includes the relevant functions and axioms used by the generated proof obligations if the program does not already include them. This is to address the problem that writing
decreases ewithout having the relevant input currently leads to a rather cryptic error message that informs the user that the functions "bounded" and "decreasing" were not found in the program, without any hint that an import is missing (and what the imported file should be).That is,
For programs that contain all relevant definitions, nothing changes. For programs that already contain some but not all required imports, only the missing ones are added.
Instead of adding new tests, this PR removes (some of) the existing imports for some termination tests.