Fix multiple apply of magic wands with quantified expressions
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to magic-wand-maps
… own function definitions to replace wand maps.
…ginal approach using MagicWandSnapSingleton.
… the original approach using MagicWandSnapSingleton." This reverts commit fd87482.
…nvert them to MWSF.
# Conflicts: # silver # src/main/scala/decider/TermToSMTLib2Converter.scala # src/main/scala/rules/HavocSupporter.scala # src/main/scala/rules/MagicWandSupporter.scala # src/main/scala/rules/MoreCompleteExhaleSupporter.scala # src/main/scala/rules/Producer.scala # src/main/scala/state/Terms.scala # src/main/scala/supporters/MagicWandSnapFunctionsContributor.scala
… the control flow.
manud99
changed the title
apply of quantified magic wandapply of magic wands with quantified expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my first PR #836 I didn't fix the
applyof magic wands with quantified expressions. In this PR I address this issue and propose a fix for all combinations of magic wands with quantified expression that I could find in silver's test suite. This PR includes:Test suite can be found in PR viperproject/silver#805