Fix metatable security. #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to LuaBridge documentation the __metatable field is set to false. But apparently this is not the case. Resulting in scripts being able to tamper with them.
It seems that __metatable is not hidden for new namespaces.
dmitry-t
requested changes
Jan 26, 2023
Comment on lines
+1044
to
+1049
| if (Security::hideMetatables()) | ||
| { | ||
| lua_pushboolean(L, 0); | ||
| rawsetfield(L, -2, "__metatable"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Spaces should be used instead of tabs.
There was a problem hiding this comment.
Is it okay for you when you just push the change under your name?
|
Can you add a unit test which fails with the original implementation and works with the change? |
|
The LuaBridge3 repo copied my fix last week + a unit test. Use that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From LuaBridge documentation:
According to Lua docuemtation the field must be set to prevent tampering with it.
Setting it to nil as it is currently done, effectively does nothing.
I went back to LuaBridge 1.0.0 where is was still correctly a boolean. Since 1.0.2 it changed to nil.
This makes me wonder if there are more security issues with LuaBridge...
Edit:
I forgot to mention that setting __metatable when constructing Namespace is missing completely. I've also added that to the PR.