Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md file #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CONTRIBUTING.md file #231

wants to merge 1 commit into from

Conversation

romainl
Copy link
Collaborator

@romainl romainl commented Feb 25, 2023

Related: #221

@habamax
Copy link
Collaborator

habamax commented Feb 26, 2023

I wonder what kind of help we need with documentation and tooling?

@romainl
Copy link
Collaborator Author

romainl commented Feb 26, 2023

We need testing, writing, opinions, etc.

Writing/updating the documentation is quite a task, actually, and I am not sure how to start it correctly.

For the tooling: feedback about checks, about colortemplate, etc.

- There are a bunch of samples in `colors/tools/` to be used for screenshots.
- It might be useful to discuss orientations with the team before going on with your template.

## Helping with documentation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although colorschemes bundled with vim do not require documentation in vim, they should work as is, we might need to document....


TBC

## helping with tooling
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're heavily dependent on Colortemplate for colorscheme authoring. Any contribution (bug reports, code fixes, documentation updates, etc) there would also help us.

There are helper scripts in colors/tools/ directory that cover different use cases, opening vim in various states to check colorschemes visually. It might be handy to have more use cases covered there or make existing scripts "deeper".

There is also pretty basic colors/tools/check_colors.vim script that is supposed to be used as a general consistency check for a new or updated colorschemes. It would be nice to enrich it with more checks and eventually organize CI/CD for each new PR to run against it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants