Merge pull request react-bootstrap#1417 from taion/MenuItem-href

[fixed] Falsy href handling on MenuItem
viktorrusakov · Oct 17, 2015 · f166109 · f166109
2 parents d4313c0 + e333c3d
commit f166109
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/MenuItem.js b/src/MenuItem.js
@@ -37,7 +37,7 @@ export default class MenuItem extends React.Component {
       );
     }
 
-    const {className, style, href, onClick, ...props} = this.props;
+    const {className, style, onClick, ...props} = this.props;
 
     const classes = {
       disabled: this.props.disabled,
@@ -53,7 +53,6 @@ export default class MenuItem extends React.Component {
           {...props}
           role="menuitem"
           tabIndex="-1"
-          href={href || ''}
           onClick={createChainedFunction(onClick, this.handleClick)}
         />
       </li>