-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[N/A] ACF Block Forms (Concept) #120
Open
bd-viget
wants to merge
69
commits into
main
Choose a base branch
from
bd/block-forms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ten1seven
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
bd-viget
force-pushed
the
bd/block-forms
branch
2 times, most recently
from
July 31, 2024 14:44
c935d24
to
d067a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a proof of concept to use ACF + ACF Blocks Toolkit to create a set of blocks that can be used create forms.
Proof of Concept Features
default
selected value.Form Data
andForm Meta
blocks, which allow you to place form fields or meta anywhere in a standard Gutenberg editor.Known Issues
[Bug] I've noticed rare instances where the Custom Unique Block IDs (ACF Blocks Toolkit) change, causing the blocks (and forms) to lose connection with anything associated with it (such as Email Templates and Conditional Logic) - I have been unable to reproduce, so maybe this is expected during experimental developmentThis has been addressed in PR [N/A] Prevent Block IDs from Changing #140innerBlocks
section and the "field", which doesn't really allow for support of a connected set of blocks below the "field". A potential solution is to create aLabel
field which serves as theinnerBlocks
area above the input, and the rest of the blocks can be placed below.Form Data
orForm Meta
blocks, they don't render in the Email Template (the default Label will display).Issues
Testing Instructions
bd/block-forms
branchScreenshots
Default Form Template
Demo Form Front-end
Demo Form Back-end
Form Submission Confirmation Message
Form Submissions Page
Email Templates
Future
I'm proposing we move this project into a separate repository so it can be managed as its own plugin, tested and QA'd, with the potential of an initial release of a basic, bare minimum functioning version.
Potential Enhancements