fix common options missing and warning #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
commented
Oct 10, 2023
| @@ -420,6 +420,8 @@ public function getOptionParser(): ConsoleOptionParser | |||
| $name = ($this->plugin ? $this->plugin . '.' : '') . $this->name; | |||
| $parser = new ConsoleOptionParser($name); | |||
|
|
|||
| $parser = $this->_setCommonOptions($parser); | |||
There was a problem hiding this comment.
This fixed the error since the common option's default values aren't set without this call.
LordSimal
commented
Oct 10, 2023
| @@ -324,7 +324,7 @@ public function templateData(Arguments $arg): array | |||
| $data['useStatements'] = array_unique(array_values(Hash::flatten($useStatements))); | |||
| } | |||
|
|
|||
| if ($data['useStatements']) { | |||
| if (!empty($data['useStatements'])) { | |||
There was a problem hiding this comment.
This fixed the warning
pabloelcolombiano
previously approved these changes
Oct 11, 2023
pabloelcolombiano
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discourse.cakephp.org/t/connection-problem-with-fixture-factory-v3-0/11569
I didn't test baking a new factory 😅
also there is another warning as well which this PR fixes