apacheGH-42121: [Java] Cleanup spotless plugin configuration (apache#…

…43019) ### What changes are included in this PR? As all modules have been migrated over to spotless, remove per-module configuration and enable java formatting at the root level. Exclude format module from java formatting but still enable license formatting for this module as well. ### Are these changes tested? Through CI/CD ### Are there any user-facing changes? No Fixes apache#42121 apache#40826 * GitHub Issue: apache#42121 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
vibhatha · Jun 25, 2024 · 3e7ae53 · 3e7ae53
1 parent fecd207
commit 3e7ae53
Show file tree

Hide file tree

Showing 78 changed files with 960 additions and 1,459 deletions.
diff --git a/java/README.md b/java/README.md
@@ -66,10 +66,7 @@ rm -rf java/format/src
 flatc --java -o java/format/src/main/java format/*.fbs
 
 # prepend license header
-find java/format/src -type f | while read file; do
-  (cat header | while read line; do echo "// $line"; done; cat $file) > $file.tmp
-  mv $file.tmp $file
-done
+mvn spotless:apply -pl :arrow-format
 ```
 
 ## Performance Tuning

diff --git a/java/adapter/avro/pom.xml b/java/adapter/avro/pom.xml
@@ -32,11 +32,6 @@ under the License.
   <description>(Contrib/Experimental) A library for converting Avro data to Arrow data.</description>
   <url>http://maven.apache.org</url>
 
-  <properties>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>org.apache.arrow</groupId>

diff --git a/java/adapter/jdbc/pom.xml b/java/adapter/jdbc/pom.xml
@@ -32,11 +32,6 @@ under the License.
   <description>(Contrib/Experimental)A library for converting JDBC data to Arrow data.</description>
   <url>http://maven.apache.org</url>
 
-  <properties>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
-  </properties>
-
   <dependencies>
 
     <dependency>

diff --git a/java/adapter/orc/pom.xml b/java/adapter/orc/pom.xml
@@ -35,8 +35,6 @@ under the License.
 
   <properties>
     <arrow.cpp.build.dir>../../../cpp/release-build/</arrow.cpp.build.dir>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
   </properties>
 
   <dependencies>

diff --git a/java/algorithm/pom.xml b/java/algorithm/pom.xml
@@ -28,11 +28,6 @@ under the License.
   <name>Arrow Algorithms</name>
   <description>(Experimental/Contrib) A collection of algorithms for working with ValueVectors.</description>
 
-  <properties>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>org.apache.arrow</groupId>

diff --git a/java/c/pom.xml b/java/c/pom.xml
@@ -32,8 +32,6 @@ under the License.
 
   <properties>
     <arrow.c.jni.dist.dir>./build</arrow.c.jni.dist.dir>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
   </properties>
 
   <dependencies>

diff --git a/java/compression/pom.xml b/java/compression/pom.xml
@@ -28,11 +28,6 @@ under the License.
   <name>Arrow Compression</name>
   <description>(Experimental/Contrib) A library for working with the compression/decompression of Arrow data.</description>
 
-  <properties>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>org.apache.arrow</groupId>

diff --git a/java/dataset/pom.xml b/java/dataset/pom.xml
@@ -34,8 +34,6 @@ under the License.
     <arrow.cpp.build.dir>../../../cpp/release-build/</arrow.cpp.build.dir>
     <parquet.version>1.14.1</parquet.version>
     <avro.version>1.11.3</avro.version>
-    <checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
-    <spotless.java.excludes>none</spotless.java.excludes>
   </properties>
 
   <dependencies>

diff --git a/java/dev/checkstyle/checkstyle-spotless.xml b/java/dev/checkstyle/checkstyle-spotless.xml