[RSDK-5633] Fix stereo depth component not setting output size correctly #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randhid
approved these changes
Jul 17, 2024
|
Gonna hold off from merging until my change is in and released in a new DepthAI release and we bump our dep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context on Jira: RSDK-5633
Sent out a related PR in the DepthAI SDK that implements the actual logic on their side (blocked from merging bc of this)
The changes in this current PR in our module is also necessary because we don't just want the closest resolution. We want the closest resolution that is larger than the given dimensions (so that cropping works properly).