-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS_BUTTON to keycodes #58
base: main
Are you sure you want to change the base?
Conversation
Did you test these keycodes, because they're not actually correct. As above we have:
so everything will be shifted 1 back |
I got the values from https://github.com/qmk/qmk_firmware/blob/master/quantum/quantum_keycodes.h#L438-L469 |
Yes, these values won't match the ones in Vial/VIA due to the |
@davewongillies try this
|
K(0x5D10, "JS_BUTTON7", "Joystick\n7", "Joystick Button 7"), | ||
K(0x5D11, "JS_BUTTON8", "Joystick\n8", "Joystick Button 8"), | ||
K(0x5D12, "JS_BUTTON9", "Joystick\n9", "Joystick Button 9"), | ||
K(0x5D13, "JS_BUTTON10" "Joystick\n10", "Joystick Button 10"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commas missing from here
Add support for joystick buttons to keycodes