Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporary expressions in reverse mode #984

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MihailMihov
Copy link
Collaborator

This PR aims to fix issues with temporary expressions in reverse mode (like in the included tests), but some of the tests are still failing, so I'm marking it as a draft

fixes #917

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Owner

@MihailMihov, can you rebase?

@MihailMihov
Copy link
Collaborator Author

@MihailMihov, can you rebase?

I don't really have anything ready on this, because I need the constructors in reverse mode to work before I can finish this. If you want I can close this for now and open another one when it's ready?

@vgvassilev
Copy link
Owner

Let's keep this opened. @parth-07 may have some good news on the ctor support in reverse soon.

@vgvassilev
Copy link
Owner

I am wondering what's the fate of this PR?

@MihailMihov
Copy link
Collaborator Author

I am wondering what's the fate of this PR?

For some time it was blocked on not having support for constructors in reverse-mode, but now that that has been merged I'll try rebasing it and seeing if the tests still fail and why.

@parth-07
Copy link
Collaborator

For some time it was blocked on not having support for constructors in reverse-mode, but now that that has been merged

The tests should still fail. We added support for custom derivatives for constructors. Clad cannot automatically differentiate constructors so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to differentiate an operator in reverse mode fails.
3 participants