Complain if signatures of forward declaration and generated gradient code do not match #836
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additionally, the tests will require extensive changes as many tests still have mismatched signatures, one such example being |
|
I would merge the two code blocks for the class method and regular function into one, but for some reason i cant seem to get Sema::LookupName to look inside classes for results |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #810 by crashing compilation whenever a mismatched gradient forward declaration is found.
There are two separate cases to handle the generated gradient code and search for a forward declaration.
If its a class/struct method, a lookup is performed in the class.
While if its a regular function, a lookup is performed in the TU.
Do let me know if any changes are necessary.