Remove Redundant Goto Statements #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue vgvassilev#526. We can only remove the goto stmt only when return statement is not inside any control flow statement
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 93.83% 93.76% -0.08%
==========================================
Files 41 41
Lines 6032 6042 +10
==========================================
+ Hits 5660 5665 +5
- Misses 372 377 +5
... and 1 file with indirect coverage changes
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Please stop opening new pull requests. I strongly encourage you to work on #608 in addition as part of our meeting we have proposed an entry point tasks to get to know the code base and git. We strongly encourage you to do that rather than keeping bombarding the repository with such PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #526. We can only remove the goto stmt only when return statement is not inside any control flow statement