Add support for array arguments in vector mode #614
Conversation
vaithak
force-pushed
the
vector-mode-array
branch
from
73ec6ae
to
0edc12c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
==========================================
+ Coverage 93.73% 93.83% +0.09%
==========================================
Files 41 41
Lines 5939 6032 +93
==========================================
+ Hits 5567 5660 +93
Misses 372 372
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -611,6 +611,25 @@ | |||
| return InstantiateTemplate(GetCladArrayDecl(), {T}); | |||
| } | |||
|
|
|||
| TemplateDecl* VisitorBase::GetCladMatrixDecl() { | |||
| static TemplateDecl* Result = nullptr; | |||
There was a problem hiding this comment.
warning: variable 'Result' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
static TemplateDecl* Result = nullptr;
^
There was a problem hiding this comment.
I am not sure I understand that diagnostics. Does it mean to add a const?
There was a problem hiding this comment.
Not sure about this, I don't get it either.
vaithak
force-pushed
the
vector-mode-array
branch
from
0edc12c
to
d1618e5
Compare
vaithak
force-pushed
the
vector-mode-array
branch
2 times, most recently
from
d42ef1a
to
06b006c
Compare
vaithak
force-pushed
the
vector-mode-array
branch
from
06b006c
to
56fe2ae
Compare
| if (!offsetExpr) { | ||
| offsetExpr = nonArrayIndVarCountExpr; | ||
| } else if (nonArrayIndVarCount != 0) { | ||
| offsetExpr = BuildOp(BinaryOperatorKind::BO_Add, offsetExpr, | ||
| nonArrayIndVarCountExpr); | ||
| } |
There was a problem hiding this comment.
We should omit the { and }. Did clang-format add them?
There was a problem hiding this comment.
Removed manually 👍🏼 , clang-format wasn't able to fix this even after adding the RemoveBracesLLVM flag; maybe because it considers else if part as multi-line?
There was a problem hiding this comment.
Probably. It's just a lexer in the end.
|
|
||
| // Push param types for derived params. | ||
| for (std::size_t i = 0; i < m_Function->getNumParams(); ++i) | ||
| for (std::size_t i = 0; i < m_Function->getNumParams(); ++i) { |
There was a problem hiding this comment.
It seems we should fix clang-format's settings...
There was a problem hiding this comment.
added RemoveBracesLLVM flag in clang-format, but this is not very reliable as stated here: https://clang.llvm.org/docs/ClangFormatStyleOptions.html
| @@ -611,6 +611,25 @@ | |||
| return InstantiateTemplate(GetCladArrayDecl(), {T}); | |||
| } | |||
|
|
|||
| TemplateDecl* VisitorBase::GetCladMatrixDecl() { | |||
| static TemplateDecl* Result = nullptr; | |||
There was a problem hiding this comment.
I am not sure I understand that diagnostics. Does it mean to add a const?
vaithak
force-pushed
the
vector-mode-array
branch
from
0a6ce09
to
c921c07
Compare
No description provided.