Add support for Kokkos::fence in the fwd mode
#1048
Conversation
gojakuch
force-pushed
the
kokkos-support-2
branch
from
b2afdb1
to
38b97c0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -6,6 +6,7 @@ | |||
| #define CLAD_DIFFERENTIATOR_KOKKOSBUILTINS_H | |||
|
|
|||
| #include <Kokkos_Core.hpp> | |||
There was a problem hiding this comment.
warning: 'Kokkos_Core.hpp' file not found [clang-diagnostic-error]
#include <Kokkos_Core.hpp>
^
There was a problem hiding this comment.
We should probably install Kokkos as part of our clang-tidy CI dependencies...
| return; | ||
| /// Fence | ||
| template <typename S> void fence_pushforward(const S& s, const S& /*d_s*/) { | ||
| ::Kokkos::fence(s); |
There was a problem hiding this comment.
warning: variable 's' is not initialized [cppcoreguidelines-init-variables]
| ::Kokkos::fence(s); | |
| ::Kokkos::fence(s = 0); |
There was a problem hiding this comment.
That seems broken, probably because my previous comment on kokkos and our CI.
There was a problem hiding this comment.
yeah, I saw this, I don't think it's a valid suggestion either :)
There was a problem hiding this comment.
Note, this is fine for forward mode but for the reverse mode we probably want d_s for the argument of the fence call to be able to identify the fences from the forward passes vs the fences of the reverse passes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 55 55
Lines 8293 8293
=======================================
Hits 7819 7819
Misses 474 474 |
|
@gojakuch, could you rebase this PR? @kliegeois, can you take a look? |
gojakuch
force-pushed
the
kokkos-support-2
branch
4 times, most recently
from
3b0acb4
to
6473e60
Compare
Although this function doesn't need to be differentiated and is correctly used by Clad automatically, this custom pushforward prevents Clad from throwing a warning during that.
gojakuch
force-pushed
the
kokkos-support-2
branch
from
6473e60
to
d00360e
Compare
Although this function doesn't need to be differentiated and is correctly used by Clad automatically, this custom pushforward prevents Clad from throwing a warning during that.
P.S. this PR has been developed on top of #1022 and should be merged after that. I just don't want to slow down the review of #1022 any longer by adding new commits to it.