Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmake error in pr #5846 #5955

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

E2ern1ty
Copy link
Contributor

@E2ern1ty E2ern1ty commented Sep 26, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#5846

Description:

给pr5846修复相关的test cmake,我看这个ci卡了几个月的了..fix一下

How do you solve it?

在FunctionManager中,新增了proxygen,所以涉及到FunctionManager相关的test就需要同样增加proxygen的库.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

fansehep and others added 5 commits September 26, 2024 16:39
(cherry picked from commit 84bb690)
Signed-off-by: alexsehep <[email protected]>
(cherry picked from commit d2b17d4)
Signed-off-by: alexsehep <[email protected]>
(cherry picked from commit 993bea6)
Signed-off-by: alexsehep <[email protected]>
(cherry picked from commit e607095)
@E2ern1ty
Copy link
Contributor Author

@Salieri-004 Can you take a look ?

@Salieri-004 Salieri-004 added ready-for-testing PR: ready for the CI test ready for review labels Sep 27, 2024
@Salieri-004
Copy link
Contributor

@Salieri-004 Can you take a look ?

OK, thanks for your help. 😸

@Salieri-004 Salieri-004 requested review from jievince, yixinglu, codesigner, czpmango and Salieri-004 and removed request for jievince September 27, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants