Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build on py36 #5800

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: fix build on py36 #5800

wants to merge 3 commits into from

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Jan 9, 2024

To build nebula-python in py36, we have to call python setup.py install (only impact those who will to build nebula-python from source in py36)

Note, the wheel built now in Nebula-Python could be installed with pip install <file>.whl

dependent on vesoft-inc/nebula-python#307

In summary, now:

  • NebulaGraph-Py supports python3.6.2+ to be installed from its package
  • in py3.7+, it could be built properly with pdm build or other tools that support pyproject.toml
  • in py3.6, if we would like to build from python repo source code, we have to do python3 setup.py install (the only draw-back, which impacted our tests makefile.)

See more from: vesoft-inc/nebula-python#308

What type of PR is this?

  • bug
  • feature
  • enhancement

To build nebula-python in py36, we have to call python setup.py install

Note, the wheel built now in Nebula-Python could be installed
with pip install <file>.whl
@jievince jievince added the ready-for-testing PR: ready for the CI test label Jan 9, 2024
@wey-gu wey-gu added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Jan 9, 2024
jievince
jievince previously approved these changes Jan 9, 2024
yixinglu
yixinglu previously approved these changes Jan 11, 2024
@wey-gu wey-gu dismissed stale reviews from jievince and yixinglu via c749dcf March 21, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants