Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(turbo-tasks): Remove T: Serialize bound from ResolveVc #69995

Open
wants to merge 2 commits into
base: bgw/resolved-vc-constructors
Choose a base branch
from
Open

fix(turbo-tasks): Remove T: Serialize bound from ResolveVc #69995

wants to merge 2 commits into from
+3 −22

Commits on Sep 19, 2024

  1. fix(turbo-tasks): Manually implement Serialize/Deserialize for Resolv… 

    …edVc

With the derived implementation, serde would inject a `T: Serialize` or
`T: Deserialize` bound.

However, like `Vc`, `ResolvedVc` is serialized as a couple numeric IDs,
so we shouldn't have this restriction on `ResolvedVc`.
    @bgw
    bgw committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1fbedd5 View commit details
    Browse the repository at this point in the history

  2. Use derived impl with bound = "" instead

    @bgw
    bgw committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e6ed35b View commit details
    Browse the repository at this point in the history