Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: route support for Astro, Nuxt, Remix, Sveltekit and Vue #151

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

feugy
Copy link
Member

@feugy feugy commented Nov 6, 2024

🖖 What's in there?

A long due story: route support to masses.
It also includes latest fix for route computation from Speed Insights.

🤺 How to test?

I brought similar tests application as we have in speed-insights to test them.

When browsing them with network tab opened, filtering "view" request, we should see pageviews (and custom events) with dp (dynamic path) property holding route values.
image

You can check real results here:

Warning you'll need to enable flag enable-web-analytics-panel-switcher in order to view page views by routes in Web Analytics
Warning these are preview branches, so you need to select preview in Web Analytics env dropdown

🔬Notes to reviewers

I know it's a lot, but you can basically ignore most of the code in apps/* and focus on the code within packages/web

🔗 Related PRs

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm
analytics-next15 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm
analytics-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm
analytics-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm
analytics-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm
analytics-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm
analytics-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:10pm

@feugy feugy requested a review from a team November 6, 2024 15:48
Copy link

socket-security bot commented Nov 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@astrojs/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +101 25.2 MB fredkschott
npm/@remix-run/[email protected] None 0 9.84 kB mjackson
npm/@remix-run/[email protected] environment, filesystem Transitive: eval, network, shell, unsafe +469 43.6 MB mjackson
npm/@remix-run/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +258 35.9 MB mjackson
npm/@sveltejs/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +75 3.41 MB svelte-admin
npm/@sveltejs/[email protected] environment, eval Transitive: filesystem +18 1.65 MB svelte-admin
npm/@sveltejs/[email protected] Transitive: environment +9 859 kB svelte-admin
npm/@swc/[email protected] None +2 208 kB kdy1, kwonoj
npm/@swc/[email protected] Transitive: environment, filesystem +17 902 kB kdy1, kwonoj
npm/@testing-library/[email protected] None +15 2.45 MB brrianalexis, cmckinstry, dfcook, ...13 more
npm/@testing-library/[email protected] environment Transitive: eval +22 4 MB testing-library-bot
npm/@types/[email protected] None +1 2.3 MB types
npm/@types/[email protected] None 0 28.8 kB types
npm/@types/[email protected] None +2 1.69 MB types
npm/@vitejs/[email protected] environment 0 193 kB vitebot
npm/[email protected] Transitive: environment, eval, filesystem, network, shell +340 57.3 MB fredkschott
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +98 10.5 MB eslintbot
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +647 139 MB danielroe
npm/[email protected] Transitive: environment, filesystem +10 5.58 MB dummdidumm, orta, svelte-language-tools-deploy
npm/[email protected] None +17 4.75 MB svelte-admin
npm/[email protected] None 0 22.4 MB typescript-bot
npm/[email protected] Transitive: environment, filesystem, network, shell +7 6.39 MB antfu, patak, soda, ...2 more
npm/[email protected] None +1 864 kB posva, yyx990803
npm/[email protected] Transitive: environment, filesystem +22 16.1 MB posva, soda, yyx990803

🚮 Removed packages: npm/@remix-run/[email protected], npm/@remix-run/[email protected], npm/@remix-run/[email protected], npm/@remix-run/[email protected], npm/@remix-run/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@tailwindcss/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vercel/[email protected], npm/@vercel/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Collaborator

@tobiaslins tobiaslins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:thank-u: for finally getting this over the finish line! great work

packages/web/src/types.ts Show resolved Hide resolved
@feugy feugy merged commit 55bd2ff into main Nov 7, 2024
13 checks passed
@feugy feugy deleted the damien/log-827-deploy-route-support-for-other-framework branch November 7, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants