-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: route support for Astro, Nuxt, Remix, Sveltekit and Vue #151
Merged
feugy
merged 3 commits into
main
from
damien/log-827-deploy-route-support-for-other-framework
Nov 7, 2024
Merged
feat: route support for Astro, Nuxt, Remix, Sveltekit and Vue #151
feugy
merged 3 commits into
main
from
damien/log-827-deploy-route-support-for-other-framework
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
feugy
force-pushed
the
damien/log-827-deploy-route-support-for-other-framework
branch
from
November 6, 2024 15:50
8c9cf45
to
590f8e3
Compare
feugy
force-pushed
the
damien/log-827-deploy-route-support-for-other-framework
branch
from
November 6, 2024 16:08
590f8e3
to
9fac0aa
Compare
feugy
force-pushed
the
damien/log-827-deploy-route-support-for-other-framework
branch
from
November 6, 2024 16:22
9fac0aa
to
00a0cc6
Compare
feugy
force-pushed
the
damien/log-827-deploy-route-support-for-other-framework
branch
from
November 6, 2024 17:00
00a0cc6
to
eb9f965
Compare
tobiaslins
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feugy
deleted the
damien/log-827-deploy-route-support-for-other-framework
branch
November 7, 2024 13:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖖 What's in there?
A long due story: route support to masses.
It also includes latest fix for route computation from Speed Insights.
🤺 How to test?
I brought similar tests application as we have in speed-insights to test them.
When browsing them with network tab opened, filtering "view" request, we should see pageviews (and custom events) with
dp
(dynamic path) property holding route values.You can check real results here:
Warning you'll need to enable flag
enable-web-analytics-panel-switcher
in order to view page views by routes in Web AnalyticsWarning these are preview branches, so you need to select preview in Web Analytics env dropdown
🔬Notes to reviewers
I know it's a lot, but you can basically ignore most of the code in
apps/*
and focus on the code withinpackages/web
🔗 Related PRs