Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (ai/core): streamText returns result immediately (no Promise) #3658

Merged
merged 7 commits into from
Nov 13, 2024
Merged

chore (ai/core): streamText returns result immediately (no Promise) #3658

merged 7 commits into from
Nov 13, 2024

Conversation

lgrammel
Copy link
Collaborator

@lgrammel lgrammel commented Nov 13, 2024 •
edited
Loading

Tasks

  • basic implementation
  • replace occurrences
  • error handling
  • 4.0 guide updates
  • manual testing
  • changeset

@lgrammel lgrammel self-assigned this Nov 13, 2024
@lgrammel lgrammel changed the title step1 chore (ai/core): streamText returns result immediately (no Promise) Nov 13, 2024
@lgrammel lgrammel marked this pull request as ready for review November 13, 2024 18:02
shaper
shaper reviewed Nov 13, 2024
View reviewed changes
content/docs/08-troubleshooting/01-migration-guide/25-migration-guide-3-1.mdx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this edit seems unintentional, as an old migration guide?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@lgrammel lgrammel merged commit f967199 into main Nov 13, 2024
8 checks passed
@lgrammel lgrammel deleted the lg/stream-text branch November 13, 2024 19:36
@patelvivekdev
Copy link

Is there any particular reason for the change from promise to no promise?

@lgrammel
Copy link
Collaborator Author

Yes - promises block immediate returns and thus prevent us from streaming back additional data using StreamData before the LLM provider responds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaper shaper shaper left review comments

@jeremyphilemon jeremyphilemon jeremyphilemon approved these changes

Assignees

@lgrammel lgrammel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgrammel @patelvivekdev @shaper @jeremyphilemon