Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): modify docs navigation hrefs for compatibility with offline documentation #9254

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Feb 4, 2024

WIP - A modern redo of #7642

Motivation

New Changes

  • Update navigation site site pinned versions
  • Resolve merge conflicts
  • Pin a version of Ruby for use with rbenv, since 3.3.0 breaks Jekyll serve

Old Changes

  • Use paths to html files in the menu bar consistently
  • Disable site features (SEO tags, statically serving data files) that aren't used by Docset in an alternate version of the docset build script

Testing

@hydrosquall
Copy link
Member Author

hydrosquall commented Feb 4, 2024

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@hydrosquall hydrosquall force-pushed the cameron.yick/experiment-doc-generation-2024 branch from 36730a7 to 7e01381 Compare February 4, 2024 17:46
@hydrosquall hydrosquall changed the title feat(docs): modify site navigation for compatibility with offline documentation feat(build): modify docs site navigation links for compatibility with offline documentation Feb 4, 2024
@@ -0,0 +1,4 @@
vega: 5.27.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generate this at build time so it doesn't need to be in the repo.

Copy link
Member Author

@hydrosquall hydrosquall Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, would it make sense for me to add this file to the .gitignore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but make sure it doesn't cause issues with the page build.

@hydrosquall hydrosquall changed the title feat(build): modify docs site navigation links for compatibility with offline documentation feat(build): modify docs navigation hrefs for compatibility with offline documentation Feb 5, 2024
@hydrosquall hydrosquall force-pushed the cameron.yick/experiment-doc-generation-2024 branch from 7e01381 to 5930cc3 Compare February 5, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants