Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): Switch regression detector to new API and analysis service #17912

Merged
merged 4 commits into from
Jul 11, 2023
Merged

chore(CI): Switch regression detector to new API and analysis service #17912

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
343ed92
Switch regression detector to new API and analysis
GeorgeHahn Jul 7, 2023
6e4f7c3
Move API env out to the whole workflow
GeorgeHahn Jul 7, 2023
7e2c3fc
Spelling: allow `curta`
GeorgeHahn Jul 7, 2023
0824733
Merge remote-tracking branch 'origin/master' into single-machine-perf…
jszwedko Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/regression.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
export REPLICAS="10"
export TOTAL_SAMPLES="600"
export P_VALUE="0.1"
export SMP_CRATE_VERSION="0.7.3"
export SMP_CRATE_VERSION="0.9.0"
export LADING_VERSION="0.12.0"

echo "warmup seconds: ${WARMUP_SECONDS}"
Expand Down Expand Up @@ -456,6 +456,8 @@
- compute-metadata
- upload-baseline-image-to-ecr
- upload-comparison-image-to-ecr
env:
SINGLE_MACHINE_PERFORMANCE_API: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_API }}
GeorgeHahn marked this conversation as resolved.
Show resolved Hide resolved
steps:
- name: Check status, in-progress
env:
Expand Down Expand Up @@ -496,6 +498,7 @@
chmod +x ${{ runner.temp }}/bin/smp

${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job submit \
--use-curta \
Fixed Show fixed Hide fixed
--lading-version ${{ needs.compute-metadata.outputs.lading-version }} \
--total-samples ${{ needs.compute-metadata.outputs.total-samples }} \
--warmup-seconds ${{ needs.compute-metadata.outputs.warmup-seconds }} \
Expand Down Expand Up @@ -525,6 +528,7 @@
chmod +x ${{ runner.temp }}/bin/smp

${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job status \
--use-curta \
Fixed Show fixed Hide fixed
--wait \
--wait-delay-seconds 60 \
--wait-timeout-minutes 90 \
Expand All @@ -537,6 +541,7 @@
run: |
chmod +x ${{ runner.temp }}/bin/smp
${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job cancel \
--use-curta \
Fixed Show fixed Hide fixed
--submission-metadata ${{ runner.temp }}/submission-metadata

- name: Check status, cancelled
Expand Down Expand Up @@ -590,6 +595,8 @@
needs:
- submit-job
- compute-metadata
env:
SINGLE_MACHINE_PERFORMANCE_API: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_API }}
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -617,6 +624,8 @@
chmod +x ${{ runner.temp }}/bin/smp

${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job result \
--use-curta \
Fixed Show fixed Hide fixed
--use-consignor \
--submission-metadata ${{ runner.temp }}/submission-metadata

- name: Check status, cancelled
Expand Down Expand Up @@ -666,6 +675,8 @@
needs:
- submit-job
- compute-metadata
env:
SINGLE_MACHINE_PERFORMANCE_API: ${{ secrets.SINGLE_MACHINE_PERFORMANCE_API }}
steps:
- name: Check status, in-progress
env:
Expand Down Expand Up @@ -708,6 +719,8 @@
chmod +x ${{ runner.temp }}/bin/smp

${{ runner.temp }}/bin/smp --team-id ${{ secrets.SINGLE_MACHINE_PERFORMANCE_TEAM_ID }} job sync \
--use-curta \
Fixed Show fixed Hide fixed
--use-consignor \
--submission-metadata ${{ runner.temp }}/submission-metadata \
--output-path "${{ runner.temp }}/outputs"

Expand Down
Loading