Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle prereleases and big numbers #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kmck
Copy link
Contributor

@kmck kmck commented Sep 14, 2019

Hey again! Came across some more issues that my last PR didn't address (or maybe introduced).

  • I'm not much of a Java programmer, and it turns out that comparing Integers with == is a problem with numbers over 127! Who knew. (Don't ask why I need this to work with giant version numbers... 😅)
  • Fixed a case where the minor version wasn't checked for ranges that omitted the patch version
  • Modified isSatisfied to properly reject prerelease versions when a non-prerelease range is specified (eg. 2.0.0-beta should not satisfy <2.0.0 even though it's a lower version)
  • Wildcard no longer matches pre-release versions. This seems to be consistent with the Node version. I was using https://semver.npmjs.com for reference

@kmck
Copy link
Contributor Author

kmck commented Sep 25, 2019

Bump! Any chance of this getting merged soon?

@kmck
Copy link
Contributor Author

kmck commented Oct 10, 2019

@vdurmont would you mind taking a look at this?

@kmck
Copy link
Contributor Author

kmck commented Nov 5, 2019

☠️

@kmck
Copy link
Contributor Author

kmck commented Oct 15, 2020

@vdurmont I made some more changes and believe it may resolve some open issues around versions. Do you think you could take a look when you get a chance?

Some of the changes in particular:

@hemikak
Copy link

hemikak commented Feb 18, 2021

@vdurmont , could we get this PR reviewed, merged and released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants