-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle prereleases and big numbers #37
Open
kmck
wants to merge
4
commits into
vdurmont:master
Choose a base branch
from
kmck:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump! Any chance of this getting merged soon? |
@vdurmont would you mind taking a look at this? |
☠️ |
@vdurmont I made some more changes and believe it may resolve some open issues around versions. Do you think you could take a look when you get a chance? Some of the changes in particular:
|
@vdurmont , could we get this PR reviewed, merged and released ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again! Came across some more issues that my last PR didn't address (or maybe introduced).
Integer
s with==
is a problem with numbers over 127! Who knew. (Don't ask why I need this to work with giant version numbers... 😅)isSatisfied
to properly reject prerelease versions when a non-prerelease range is specified (eg.2.0.0-beta
should not satisfy<2.0.0
even though it's a lower version)