Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM satisfies issue with optional version #48

Open
andrewvsk opened this issue Sep 17, 2020 · 3 comments
Open

NPM satisfies issue with optional version #48

andrewvsk opened this issue Sep 17, 2020 · 3 comments

Comments

@andrewvsk
Copy link

andrewvsk commented Sep 17, 2020

What I am doing wrong?

new Semver("2", SemverType.NPM).isGreaterThanOrEqualTo("2.x"); // true

new Semver("2", SemverType.NPM).isGreaterThanOrEqualTo("2"); // true
new Semver("2", SemverType.NPM).isGreaterThanOrEqualTo("2.0"); // true
new Semver("2", SemverType.NPM).isGreaterThanOrEqualTo("2.0.0"); // false ?

new Semver("2", SemverType.NPM).isGreaterThanOrEqualTo("2.0.0"); // false ?
new Semver("2.0", SemverType.NPM).isGreaterThanOrEqualTo("2.0.0"); // false ?
new Semver("2.0.0", SemverType.NPM).isGreaterThanOrEqualTo("2.0.0"); // true

new Semver("2", SemverType.NPM).satisfies(">=2.0.0"); // false ?
new Semver("2.0", SemverType.NPM).satisfies(">=2.0.0"); // false ?
new Semver("2.0", SemverType.NPM).satisfies("2.0.x"); // false ?
new Semver("2.0.0", SemverType.NPM).satisfies("2.0.x"); // true !

new Semver("2", SemverType.NPM).satisfies(">=2.0"); // true
new Semver("2.0", SemverType.NPM).satisfies(">=2.0"); // true
new Semver("2.0.0", SemverType.NPM).satisfies(">=2.0"); // true

new Semver("2", SemverType.NPM).satisfies(">=2"); // true
new Semver("2.0", SemverType.NPM).satisfies(">=2"); // true
new Semver("2.0.0", SemverType.NPM).satisfies(">=2"); // true

new Semver("2", SemverType.NPM).satisfies("~2"); // false ?
new Semver("2.0", SemverType.NPM).satisfies("~2"); // false ?
new Semver("2.0.0", SemverType.NPM).satisfies("~2"); // true !
@viebel
Copy link
Contributor

viebel commented Oct 5, 2020

I am also surprised that:

new Semver("5.1.2", SemverType.NPM).satisfies("<5.2"); // false ?

@vdurmont Could you clarify if it is expected or if it is a bug?

I am not sure that "<5.2" is a valid npm requirement but in that case, (Requirement/buildNPM "<5.2") should throw an exception.

@PhantomYdn
Copy link

Have similiar issue:

new Semver("3.0.0-beta.1", SemverType.NPM).satisfies("<3");  //false ?

@piotrooo
Copy link

@andrewvsk if you are still interesting, I've made copy of this lib and fix bug reported by you. Look for version 2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants