Backport PR #2644 to release/v1.7 for refactor(gateway): delete unused file #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vald with
|
| Latest commit: |
a3ae9eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48fca8ff.vald.pages.dev |
| Branch Preview URL: | https://backport-release-v1-7-refact-ryjt.vald.pages.dev |
📝 WalkthroughWalkthroughThe pull request involves the complete removal of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files not reviewed due to no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
kpango
approved these changes
Sep 27, 2024
|
[CHATOPS:HELP] ChatOps commands.
|
kpango
deleted the
backport/release/v1.7/refactoring/gateway/delete-unused-file
branch
|
[GEN TEST] Failed to generate tests. Error: |
1 similar comment
|
[GEN TEST] Failed to generate tests. Error: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v1.7 #2646 +/- ##
===============================================
Coverage ? 24.36%
===============================================
Files ? 536
Lines ? 46459
Branches ? 0
===============================================
Hits ? 11319
Misses ? 34372
Partials ? 768 ☔ View full report in Codecov by Sentry. |
|
[REBASE] Failed to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The file
pkg/gateway/internal/location/location_test.goexists but is not used.This PR removes
pkg/gateway/internal/location/location_test.go, which is not used.Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit
location_test.gofile, which contained licensing information and package declarations but no functional code or tests.