Refactor test checkFunc condition #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <[email protected]>
WalkthroughWalkthroughThe pull request modifies the conditional checks in the test functions Changes
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
size/S
type/bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2599 +/- ##
==========================================
+ Coverage 24.55% 24.56% +0.01%
==========================================
Files 530 530
Lines 45522 45522
==========================================
+ Hits 11176 11181 +5
+ Misses 33596 33592 -4
+ Partials 750 749 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: vankichi <[email protected]>
Deploying vald with
|
| Latest commit: |
fbeb95f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a64069ce.vald.pages.dev |
| Branch Preview URL: | https://bugfix-internal-fix-gen-test.vald.pages.dev |
Signed-off-by: vankichi <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- internal/test/data/vector/gen_test.go (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- internal/test/data/vector/gen_test.go
vankichi
requested review from
a team,
kmrmt and
hlts2
and removed request for
a team
vankichi
changed the title
kmrmt
approved these changes
Sep 10, 2024
vdaas-ci
pushed a commit
that referenced
this pull request
Sep 10, 2024
* 🐛 ✅ Fix checkFun condition Signed-off-by: vankichi <[email protected]> * ♻️ Fix by feedback Signed-off-by: vankichi <[email protected]> * ♻️ Fix by feedback Signed-off-by: vankichi <[email protected]> --------- Signed-off-by: vankichi <[email protected]>
vankichi
added a commit
that referenced
this pull request
Sep 11, 2024
* 🐛 ✅ Fix checkFun condition * ♻️ Fix by feedback * ♻️ Fix by feedback --------- Signed-off-by: vankichi <[email protected]> Co-authored-by: Kiichiro YUKAWA <[email protected]>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit