Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] modified apiversion capabilities check #2143

Closed
wants to merge 4 commits into from

Conversation

datelier
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@datelier datelier requested review from a team, kmrmt and ykadowak and removed request for a team July 31, 2023 06:49
kpango
kpango previously approved these changes Jul 31, 2023
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykadowak
Copy link
Contributor

ykadowak commented Aug 1, 2023

Can you check the E2E tests?
https://github.com/vdaas/vald/actions/runs/5711154251

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f233b4
Status: ✅  Deploy successful!
Preview URL: https://4953a61e.vald.pages.dev
Branch Preview URL: https://feature-helm-check-apiversio.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 1, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 2, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@datelier datelier changed the title modified apiversion capabilities check [do not merge] modified apiversion capabilities check Aug 2, 2023
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 2, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@datelier datelier closed this Aug 3, 2023
@datelier datelier deleted the feature/helm/check-apiversion branch August 3, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants