Sectorization re-design over Türkiye (Datafile) #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All sector definitions added.
Adrian2k
requested changes
Aug 25, 2024
There was a problem hiding this comment.
The names are geetting quite long.
I would recommend shortening the names as for example:
Ankara Control - Ankara Sector 1 -> Ankara (Sector 1)
When the sector is online, it should display as Ankara (Sector 1) control instead of Ankara Control - Ankara Sector 1 control
VATSpy.dat
Outdated
| LTBB|Ankara Control - Ankara 5 Sector|ANK_5|LTBB | ||
| LTBB|Ankara Control - Ankara 6 Sector|ANK_6|LTBB | ||
| LTAA|Ankara||LTAA | ||
| LTAA-A|Ankara Control - Ankara Central & East|ANK_A|LTAA |
There was a problem hiding this comment.
Missing -A at the very end
There was a problem hiding this comment.
Hello Adrian. this needs to stay like this; because with my PR, LTAA-A polygon will be renamed as LTAA.
I already tested this and working very good.
while offline:
while ANK_A_CTR online:
3 tasks
Adrian2k
changed the title
Names are shortened upon Adrian's request
|
Sector names are shortened as per your request. thanks for feedback! |
Adrian2k
approved these changes
Aug 26, 2024
|
Can be merged when #853 is approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
All sector definitions added.
All sub sectors are updated according to https://www.trvacc.net/sector/
Reason and motivation
Reduce to misunderstanding of sector coverage, which is a big problem for all ATC in these days.
Approved contributior?