Release #4
Merged
Release #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[API] add priority in chapter create and update [API] add priority in page create and update
Kept existing "COMMENTED_ON" activity for upgrade compatibility, specifically for existing webhook usage and for showing comment activities in activity lists. Precursor to content notifications. Currently untested. Also applied some type updates.
Includes testing to cover. Also added file missing from previous commit.
Added DB and started controller method.
Got watch system working to an initial base state. Moved some existing logic where it makes sense.
Put together an initial notification. Started logic to query and identify watchers.
Also rolled out watch UI to chapter and page views
- Adds option filtering and alternative text for page watch options. - Adds "Watched & Ignored Items" list to user notification preferences page to show existing watched items.
- Added general user preferences view and updated link in profile menu to suit. - Made notification permission required for notification preferences view, added test to cover.
- Updated mail notification design to be a bit prettier, and extracted text to new lang file for translation. - Added debounce logic for page update notifications. - Fixed watch options not being filtered to current user.
Covers core case scenarios, and check of notification content.
- Added titles for preference pages. - Added extra check for non-guest for notifications on preferences page.
- Ensured watch options passed in all meta template usage to fix failing scenarios where watch options did not exist. - Fixed testing issue caused by guest user permission caching.
Added test and changed logic to properly check the view permissions for the notification receiver before sending. Required change to permissions applicator to allow the user to be manually determined, and a service provider update to provide the class as a singleton without a specific user, so it checks the current logged in user on demand.
…cations Content user notifications
Updated status endpoint cache check to include a random component in the key to avoid conflict during simultaneous checks. For BookStackApp#4396
Included unit tests to cover validator functionality. Added to webhooks. Still need to do testing specifically for webhooks.
- Covered webhook SSR allow list useage via test. - Updated allow list handling to use trailing slash, or hash, or end of line as late anchor for better handling for hosts (prevent .co.uk passing for .co domain host)
Added min-height to flex elements to ensure they properly flex within the container rathen than adjust to content. For BookStackApp#4466
- This ensures content notifications are not translated to receiver language. - This adds actual plaintext support for content notifications (Was previously just HTML as text view). - Shares same base class across all mail notifications. - Also cleaned up existing notification classes. Future cleanup requested via BookStackApp#4501
- Passed decode flags to provide consistent behaviour across PHP versions during testing. - Added env option to prevent local option taking action in PHPunit tests.
…anguage Notifications: User language for notification text
- Adds filtering to the watched items list in notification preferences so that deleted (recycle bin) items are removed via query. - Adds relations and logic to properly remove watches upon user and entity delete events, to old watches in database do not linger. - Adds testing to cover the above. Did not add migration for existing data, since patch will be close to introduction, and lingering DB entries don't open a security concern, just some potential confusion in specific potential scenarios. Probably not work extra migration risk, although could add in future if concerns/issues are found. Related to BookStackApp#4499
Improved wrapping and flex control to prevent button text force wrapping to newlines. For BookStackApp#4502
Could error upon div elements without classes, including drawings. Related to BookStackApp#4510 and BookStackApp#4509
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.