update #3
Merged
update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does increase bundle size massively though, Will need to think about solutions for this.
Cannot find existing option for twig/smarty, need to look other methods.
Content-Permissions API Endpoints
Image API Endpoints
This is useful when developing and on Docker setups. Despite setting encryption to null, if a server supports STARTTLS with a self-signed certificate, the mailer try to upgrade the connection with STARTTLS.
Caused by input not being part of the submitted form. Updated test to ensure the input is within a form. For BookStackApp#4124
Updated content sync and preview scoll sync to work. Many features commented out until they can be updated.
Occured when the cell contained any block content with a differnt line height to the table cell itself. In firefox, cells with a height would end up with an actual greater real cell height, which messed up TinyMCE resize calculations, causing tables to grow. Adding default vertical-align: top, changes this behaviour to get proper cell heights. Related to Firefox issue: https://bugzilla.mozilla.org/show_bug.cgi?id=569645 Have tested that editor cell text align options can still be used with this. For BookStackApp#4337
Remove the book attribute in responses because it is never returned by the API. Currently, Chapters Create does not return book_slug! (The example response is consistent with the inconsistent API behavior)
Added test to cover core role sorting functionality. For BookStackApp#4350
Primarily to support long ipv6 addresses which would overflow over the activity date. For BookStackApp#4349
Update API Docs
Due to queue serialization. Added a test to check a couple of delete events. Added ApiTokenFactory to support. Also made a couple of typing/doc updates while there. Related to BookStackApp#4373
Reverted work in 847a57a. Left test in but updated to new expectation. Left migration in but removed content to prevent new pre-v23.06 upgraders loosing shelf create permission status. Added note to permission to describe use-case. For BookStackApp#4375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.