Add basic Sendable correctness, update to SQLite 3.43.1 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xTim
approved these changes
May 19, 2023
| } | ||
| extension UnsafeTransfer: Equatable where Wrapped: Equatable {} | ||
| extension UnsafeTransfer: Hashable where Wrapped: Hashable {} | ||
|
|
||
| final class UnsafeMutableTransferBox<Wrapped>: @unchecked Sendable { |
There was a problem hiding this comment.
I think we could use NIOLoopBoundBox in these instances but open to keeping what we have
There was a problem hiding this comment.
@gwynne either way Wrapped should be Sendable otherwise mutating it is even less safe. Since SQLLiteRow is already Sendable, you could just add the Sendable constraint.
…piler warnings. Also satisfy ExistentialAny requirements.
…dd a missing `private` and a missing `final` in the same file.
gwynne
force-pushed
the
sendable-checking
branch
from
c4a6a48
to
e263e27
Compare
gwynne
changed the title
…ames of the generated files to use the more consistent prefixing, and tweak the source patch to not need updating with every SQLite version.
gwynne
force-pushed
the
sendable-checking
branch
from
e263e27
to
cc75a1a
Compare
gwynne
added
semver-minor
0xTim
reviewed
Sep 13, 2023
gwynne
force-pushed
the
sendable-checking
branch
from
67e1fbd
to
822ca66
Compare
…s not valid even to compile on non-Apple platforms.
|
API breakage failure is spurious. Dependents check failure is fixed by vapor/sqlite-kit#105. |
0xTim
approved these changes
Sep 15, 2023
MahdiBM
reviewed
Sep 15, 2023
MahdiBM
requested changes
Sep 15, 2023
Plugins/VendorSQLite/AsyncNotOmittingEmptySubsequencesLineSequence.swift
Outdated
Show resolved
Hide resolved
| } | ||
| extension UnsafeTransfer: Equatable where Wrapped: Equatable {} | ||
| extension UnsafeTransfer: Hashable where Wrapped: Hashable {} | ||
|
|
||
| final class UnsafeMutableTransferBox<Wrapped>: @unchecked Sendable { |
There was a problem hiding this comment.
@gwynne either way Wrapped should be Sendable otherwise mutating it is even less safe. Since SQLLiteRow is already Sendable, you could just add the Sendable constraint.
…mselves Sendable, despite it being pointless.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 8 8
Lines 669 669
=======================================
Hits 444 444
Misses 225 225
|
MahdiBM
approved these changes
Sep 15, 2023
|
These changes are now available in 1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this release:
StrictConcurrency=completewith no warnings in this package.ExistentialAny.swift package --disable-sandbox vendor-sqlite. Accepts--help,--verbose, and--forceoptions. (Users should not need to run this command.)SQLCustomFunctionfeature's API documentation has been heavily improved.