Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extend not rendered when wrapped by with #129

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

benblakely
Copy link
Contributor

@benblakely benblakely commented Dec 8, 2023

These changes are now available in 1.10.4

When an #extend was wrapped by a #with, the #extend wasn't rendered.

Fixes #128

When an `#extend` was wrapped by a `#with`, the `#extend` wasn't rendered.

Fixes vapor#128
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Merging #129 (63f8ad9) into main (547a134) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   81.95%   82.08%   +0.12%     
==========================================
  Files          25       25              
  Lines        2593     2595       +2     
==========================================
+ Hits         2125     2130       +5     
+ Misses        468      465       -3     
Files Coverage Δ
Sources/LeafKit/LeafSyntax/LeafSyntax.swift 90.65% <100.00%> (+1.21%) ⬆️

... and 1 file with indirect coverage changes

@gwynne
Copy link
Member

gwynne commented Dec 8, 2023

This looks fine at a glance, but I'd feel better if you could add another test or two that shows (or at least tries to show, since you can't necessarily prove a negative) that this change doesn't accidentally allow otherwise invalid syntax. (I can't claim to have dealt with the LeafKit code anywhere near recently enough to be able to suggest anything more specific than that, unfortunately 😕. @0xTim might, though.)

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels Dec 8, 2023
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I think we're good here as it was mainly an oversight when the with tag was added

@0xTim 0xTim merged commit 38e3144 into vapor:main Mar 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#extend not rendered when wrapped by #with
4 participants