fix(integration): Don't update filescope if already set #1446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising the PR to get the discussion started.
Fixes Issues:-
If we try to consume a library build on Vanilla Extract which just transpiles the styles files, then this replacement of
setFileScope
causes issues in classNames not being consistent because the server takes from the cjs build while client takes form the esm build. This causes the hash of the classNames to differ since @vanilla-extract/integration package again updates the fileScope but differently for cjs and esm files.I think if the fileScope is already set by the library author, then the consumer app should not be updating it again. 🤔 I may not fully understand the reason why this is done, but I'm happy to help and contribute