fix: some pending stand by transaction not getting cleaned up #6224
Conversation
src/transactions/slice.ts
Outdated
| @@ -246,7 +246,7 @@ const slice = createSlice({ | |||
| * - ignore pending as it should only affect confirmed transactions that are already | |||
There was a problem hiding this comment.
should this comment also be removed? i don't really understand what it means, but it seems like the pending transactions were intentionally checked before
There was a problem hiding this comment.
Ah, you're right! Forgot to remove, sorry!
There was a problem hiding this comment.
@kathaypacific fixed!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6224 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 736 736
Lines 31407 31407
Branches 5809 5809
==========================================
- Hits 27944 27943 -1
- Misses 3265 3266 +1
Partials 198 198
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Description
The saga that is watching for pending transactions to turn into completed is not reporting certain transactions' status correctly. It was tested that when swapping from USDC(Optimism) to USDC(Celo):
This PR fixes this by doing more thorough cleanup of stand by transactions, once they appear in Zerion's response. Previously, we didn't clean pending transactions up and this PR fixes that as if we get any transaction from Zerion - we should use it as a source of truth.
Test plan
Existing tests pass.
Related issues
N/A
Backwards compatibility
Yes
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: