Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data loss when the old primary takes over the slots after online #974

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

print the logs first and then save the config, in case the save fails…

b395193
Select commit
Loading
Failed to load commit list.
Open

Fix data loss when the old primary takes over the slots after online #974

print the logs first and then save the config, in case the save fails…
b395193
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 31, 2024 in 1s

70.47% (-0.04%) compared to fea49bc

View this Pull Request on Codecov

70.47% (-0.04%) compared to fea49bc

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.47%. Comparing base (fea49bc) to head (b395193).

Files with missing lines Patch % Lines
src/cluster_legacy.c 50.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #974      +/-   ##
============================================
- Coverage     70.50%   70.47%   -0.04%     
============================================
  Files           114      114              
  Lines         61742    61750       +8     
============================================
- Hits          43532    43519      -13     
- Misses        18210    18231      +21     
Files with missing lines Coverage Δ
src/cluster_legacy.c 85.99% <50.00%> (+<0.01%) ⬆️

... and 10 files with indirect coverage changes