Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flushdb option for repl-diskless-load #909

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

kronwerk
Copy link

once upon a time it was an initial way to make diskless replication - without any checks.
but it was frown away because it's dangerous (and it is still dangerous, of course).
but in some situations for some users, that think they know what they're doing, it's ok.

let's pls allow this for those. thx

@kronwerk kronwerk force-pushed the unstable branch 2 times, most recently from 789a3fd to 7eccdd3 Compare August 14, 2024 11:44
@kronwerk kronwerk marked this pull request as ready for review August 14, 2024 11:46
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (9f8185f) to head (8116d29).
Report is 7 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #909      +/-   ##
============================================
+ Coverage     70.59%   70.61%   +0.01%     
============================================
  Files           114      114              
  Lines         61670    61671       +1     
============================================
+ Hits          43538    43550      +12     
+ Misses        18132    18121      -11     
Files with missing lines Coverage Δ
src/config.c 78.69% <ø> (ø)
src/replication.c 87.91% <100.00%> (+0.66%) ⬆️
src/server.h 100.00% <ø> (ø)

... and 16 files with indirect coverage changes

kronwerk and others added 2 commits August 19, 2024 19:12
Signed-off-by: kronwerk <>
Signed-off-by: kronwerk <[email protected]>
Signed-off-by: kronwerk <[email protected]>
@madolson madolson added the major-decision-pending Major decision pending by TSC team label Sep 1, 2024
@PingXie
Copy link
Member

PingXie commented Sep 20, 2024

I think this is a reasonable policy to add and it doesn't increase the complexity.

@valkey-io/core-team

Copy link
Member

@enjoy-binbin enjoy-binbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am ok with this, i mention this option in #653 (comment)

@zuiderkwast
Copy link
Contributor

It seems OK, but maybe risky that some users lose data by mistake.

but in some situations for some users, that think they know what they're doing, it's ok.

What is the use case? Why don't they want to explicitly call FLUSHALL before starting replication?

If we require them to do it explicitly, it is less likely that some user will lose data by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-decision-pending Major decision pending by TSC team
Projects
Status: Idea
Development

Successfully merging this pull request may close these issues.

6 participants