Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Fix node exports #2337

Open
wants to merge 4 commits into
base: release-1.1
Choose a base branch
from
+9 −15
Open

Node: Fix node exports #2337

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0b2d44
Fix node exports
jamesx-improving Sep 21, 2024
779e0a2
address comment
jamesx-improving Sep 21, 2024
0c87150
Remove PubSubSubscriptions as an exportable
acarbonetto Sep 21, 2024
0694483
Changelog
acarbonetto Sep 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions node/npm/glide/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,19 +185,18 @@ function initialize() {
SignedEncoding,
UnsignedEncoding,
UpdateByScore,
createLeakedArray,
createLeakedAttribute,
createLeakedBigint,
createLeakedDouble,
createLeakedMap,
createLeakedString,
parseInfoResponse,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avifenesh can you confirm that these functions can be removed?
They were added as part of 5eeb673#diff-90759696d403370b4263a25799d215fe2cd1471e7ae440426c8177f636aa5bac, but it's unclear why they are needed (needed for alpine?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. These functions are only used in tests. We should consider reworking this. Maybe using a compile flag to generate these functions for test only. They do not need to be added to production code.
Also note: createLeakedStringVec is used in production code, however this function is not exported from the package module.

Script,
ObjectType,
ClusterScanCursor,
BaseClientConfiguration,
GlideClusterClientConfiguration,
LevelOptions,
ReturnTypeRecord,
ReturnTypeMap,
WritePromiseOptions,
jamesx-improving marked this conversation as resolved.
Show resolved Hide resolved
ClusterResponse,
ReturnTypeAttribute,
PubSubSubscriptions,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove. PubSubSubscriptions is already exported as part of their respective namespaces.

} = nativeBinding;

module.exports = {
Expand Down Expand Up @@ -304,19 +303,18 @@ function initialize() {
SignedEncoding,
UnsignedEncoding,
UpdateByScore,
createLeakedArray,
createLeakedAttribute,
createLeakedBigint,
createLeakedDouble,
createLeakedMap,
createLeakedString,
parseInfoResponse,
Script,
ObjectType,
ClusterScanCursor,
BaseClientConfiguration,
GlideClusterClientConfiguration,
LevelOptions,
ReturnTypeRecord,
ReturnTypeMap,
WritePromiseOptions,
ClusterResponse,
ReturnTypeAttribute,
PubSubSubscriptions,
};

globalObject = Object.assign(global, nativeBinding);
Expand Down
Loading