Improve retry semantics #2330
Open
Improve retry semantics #2330
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a. Absence of command retry configuration in client creation params making retry mechanics unexpected, confusing and inconsistent with command timeout constrains. b. Retry semantics are inconsistent between the CME and CMD client since CMD lacks the retry logic 2. Integrate fix for retry logic in redis-rs, cancelling the request in case the future was canceled. This will allow for a correct implementation of retry logic when its configuration is exposed to the user.
ikolomi
added
Rust core
Core changes
ikolomi
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
eifrah-aws
approved these changes
Sep 19, 2024
|
You're missing DCO. |
Yury-Fridlyand
requested changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable command retries for CME connections due to:
a. Absence of command retry configuration in client creation params making retry mechanics unexpected, confusing and
inconsistent with command timeout constrains.
b. Retry semantics are inconsistent between the CME and CMD client since CMD lacks the retry logic
Integrate fix for retry logic in redis-rs, cancelling the request in case the future was canceled. This will allow for a correct implementation of retry logic when its configuration is exposed to the user.
Issue: #2251