Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: fix createCluster call #2295

Open
wants to merge 8 commits into
base: release-1.1
Choose a base branch
from

Conversation

adarovadya
Copy link
Collaborator

No description provided.

Adar Ovadia added 8 commits September 15, 2024 09:03
@adarovadya adarovadya requested a review from a team as a code owner September 16, 2024 12:36
@@ -108,6 +108,7 @@ jobs:
if ${{ env.EVENT_NAME == 'pull_request' }}; then
R_VERSION="255.255.255"
elif ${{ env.EVENT_NAME == 'workflow_dispatch' }}; then
echo "${{env.EVENT_NAME}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

echo "${GITHUB_REF:11}"
export package_version=${GITHUB_REF:11}

echo "The workflow is: ${{env.EVENT_NAME}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

@Yury-Fridlyand Yury-Fridlyand added the node Node.js wrapper label Sep 17, 2024
@avifenesh
Copy link
Collaborator

Is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants