Node: update transactions binary args returns #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
force-pushed
the
node/acarbo_update_transactions_binary_args_returns
branch
2 times, most recently
from
d9ce867
to
2e9f3b1
Compare
acarbonetto
force-pushed
the
node/acarbo_update_transactions_binary_args_returns
branch
2 times, most recently
from
60b64d0
to
7af772c
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
node/acarbo_update_transactions_binary_args_returns
branch
from
7af772c
to
da7bf93
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
| member7, | ||
| palermo, | ||
| catania, | ||
| ] = [ |
There was a problem hiding this comment.
What is the benefit of that? It just takes twice more locs
| @@ -1205,7 +1310,10 @@ export async function transactionTest( | |||
| responseData.push(["zremRangeByLex(key8, -Inf, +Inf)", 0]); // key8 is already empty | |||
|
|
|||
| if (gte(version, "7.0.0")) { | |||
| baseTransaction.zadd(key14, { one: 1.0, two: 2.0 }); | |||
| baseTransaction.zadd(key14, [ | |||
There was a problem hiding this comment.
old API shold work as well, so you can keep both
There was a problem hiding this comment.
I suppose, but why?
| @@ -1681,7 +1823,11 @@ export async function transactionTest( | |||
| responseData.push(["functionList({ libName, true})", []]); | |||
|
|
|||
| baseTransaction | |||
| .mset({ [key1]: "abcd", [key2]: "bcde", [key3]: "wxyz" }) | |||
| .mset([ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates transaction tests to run with decoder string or bytes.
Testing was responsible for finding: #2325