-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Add option to run IT on remote ports. #2156
Merged
Yury-Fridlyand
merged 6 commits into
valkey-io:main
from
Bit-Quill:java/yuryf-run-IT-on-existing-server
Oct 7, 2024
Merged
Java: Add option to run IT on remote ports. #2156
Yury-Fridlyand
merged 6 commits into
valkey-io:main
from
Bit-Quill:java/yuryf-run-IT-on-existing-server
Oct 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
added
java
issues and fixes related to the java client
testing
Everything about testing
labels
Aug 19, 2024
acarbonetto
changed the title
Java: Add option to run IT on existing servers.
Java: Add option to run IT on remote ports.
Aug 19, 2024
jonathanl-bq
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but honestly, someone else should probably read through the build.gradle changes.
Signed-off-by: Yury-Fridlyand <[email protected]>
Merged
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Oct 3, 2024
prateek-kumar-improving
approved these changes
Oct 7, 2024
prateek-kumar-improving
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Add option to run IT on existing servers. Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #1375 to java client
To run IT:
To run IT on existing servers, add this to command line (update ports according to your setup):
Additional parameter to enable TLS
To filter IT and run all tests from a specific class, add this to the command line:
To filter IT and run a very specific test, add this to the command line:
Also this PR allows to use a remote-hosted server for testing.