Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add option to run IT on remote ports. #2156

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Aug 19, 2024

Implementing #1375 to java client

To run IT:

./gradlew :integTest:test

To run IT on existing servers, add this to command line (update ports according to your setup):

-Dcluster-endpoints=localhost:7000 -Dstandalone-endpoints=localhost:6379

Additional parameter to enable TLS

-Dtls=true

To filter IT and run all tests from a specific class, add this to the command line:

--tests <classname>

To filter IT and run a very specific test, add this to the command line:

--tests '*.<test_name>'

⚠️ use quotes

Also this PR allows to use a remote-hosted server for testing.

@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client testing Everything about testing labels Aug 19, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner August 19, 2024 16:58
@acarbonetto acarbonetto changed the title Java: Add option to run IT on existing servers. Java: Add option to run IT on remote ports. Aug 19, 2024
Copy link
Collaborator

@jonathanl-bq jonathanl-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but honestly, someone else should probably read through the build.gradle changes.

Signed-off-by: Yury-Fridlyand <[email protected]>
java/DEVELOPER.md Outdated Show resolved Hide resolved
java/DEVELOPER.md Outdated Show resolved Hide resolved
java/DEVELOPER.md Show resolved Hide resolved
@Yury-Fridlyand Yury-Fridlyand merged commit 6d0cffe into valkey-io:main Oct 7, 2024
13 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/yuryf-run-IT-on-existing-server branch October 7, 2024 17:44
prateek-kumar-improving pushed a commit that referenced this pull request Oct 8, 2024
* Add option to run IT on existing servers.

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client testing Everything about testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants