CI - Minimal and full CI matrix impl #2051

avifenesh · 2024-07-30T10:34:46Z

Limited the CI to run on PR and PUSH to run just on Ubuntu-latest and latest and last version supported for engine and language version.
Added Schedule run daily, one hour in between each workflow, start from 3 AM, GMT+3.
Updated with all Node.js versions supported.
Added DEVELOPER.md with some info in it, will need to be wider, but it will be part of separate task.
Dispatch accept input for running full matrix (bool).

Labels can't be tested before merged to main as well as schedule, so test will happen live, since it will run or not, and has no optional bad outcomes it is okay.

In this PR changes worked as expected.

…ed schedule and label runs Signed-off-by: avifenesh <[email protected]>

Signed-off-by: avifenesh <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

avifenesh

All over all great job, added many comments to make it perfect but great job, much appreciated

avifenesh · 2024-09-01T14:56:26Z

.github/DEVELOPER.md

+`Build matrix`
+`Shared dependencies installation`
+`Linting (Rust)`
+


After the first healthy run, full and minimal, we can add.

avifenesh · 2024-09-01T14:58:52Z

.github/json_matrices/engine-matrix.json

-    "type": "valkey",
-    "version": "8.0.0-rc1"
-  }
+    {


Good initiative with 8,
@barshaul about minors, how do we choose which to run? There's 7.2.4/5/6 for ValKey, base on what we're taking one over the other?

avifenesh · 2024-09-01T15:01:48Z

.github/json_matrices/supported-language-versions.json

@@ -0,0 +1,27 @@
+[
+    {


I did it myself in your recommendation, but why we run just one when there's less option? I think it's not the amount available, it's about testing the supported range with the highest and lowest, so if we support just two version this is our range, and we test all of it.

Same for go and C# altho maybe C# is not under current development, so there's no need, we just want to keep it kind of under control.

Agree.
C# CI can be kept there, it is not triggered unless we change something in common CI files or in GLIDE core.
BTW, we can deactivate C# CI at all:

avifenesh · 2024-09-01T15:07:53Z

.github/json_matrices/supported-language-versions.json

+        "always-run-versions": ["8.0"]
+    },
+    {
+        "language": "go",


Why does are the chosen versions?
@MikeMwita can you give your opinion about the Go versions that should be tested? Does some have significant differences?

version 1.22.0 is okay

Copied from go CI. Proposals are welcome.
BTW I need to test empty version array (e.g. empty matrix)

avifenesh · 2024-09-01T15:08:54Z

.github/json_matrices/supported-languages-versions.json

@@ -0,0 +1,17 @@
+[


Why both files?

Oh thanks, I missed to delete that on.

avifenesh · 2024-09-01T15:33:26Z

.github/workflows/nightly.yml

+on:
+    workflow_dispatch: # note: if started manually, it won't run all matrix
+    schedule:
+        - cron: "0 3 * * *"  #  Runs at 03:00 (3 AM) UTC every day


Is it good time for you guys as well? We should try to make it as less hurting as possible, for us if everything ends by 7 AM we are good. Let's calculate from there backwards.

UTC Midnight occurs during our workday. This job will completely destroy the CI queue by adding ~200 jobs.
https://github.com/Yury-Fridlyand/valkey-glide/actions/runs/10641495001

There are 120 jobs for python (60 + 60, because PubSub IT are in separate job)

24 for java (will be 48 once I split pubsub too)

24 for C# (could be deactivated)

12 for go

100 for node

20 for glide core lib

I don't know how much time this might take. It depends on number of runners available on valkey org and on number of other nightly jobs (valkey repo has also nightly CI jobs)

avifenesh · 2024-09-01T15:38:16Z

.github/workflows/nightly.yml

+name: Nightly tests
+
+on:
+    workflow_dispatch: # note: if started manually, it won't run all matrix


Can we add the option to choose full or not?

It did not work for me. I'll try to fix it and restore.

avifenesh · 2024-09-01T15:38:38Z

.github/workflows/nightly.yml

+        - cron: "0 3 * * *"  #  Runs at 03:00 (3 AM) UTC every day
+
+concurrency:
+    group: nightly-${{ github.head_ref || github.ref }}-${{ inputs }}


What is the meaning of inputs here?

Oh, I need to restore input or remove it from there.
The goal was to distiguish the full and partial jobs.

avifenesh · 2024-09-01T15:40:06Z

.github/workflows/node.yml

@@ -128,52 +143,8 @@ jobs:
                  cargo-toml-folder: ./node/rust-client
              name: lint node rust

-    # build-macos-latest:


avifenesh · 2024-09-01T15:41:58Z

.github/workflows/python.yml

@@ -141,57 +146,41 @@ jobs:
                      utils/clusters/**
                      benchmarks/results/**

-    test-pubsub:
+    test-pubsub-python:


Not part of the scope of the PR, but can you add a comment that we run it separately because python testing cant handle the load?

avifenesh · 2024-09-01T15:49:56Z

.github/DEVELOPER.md

+
+TODO: Add a description of the CI/CD workflow and its components.
+
+### Overview


The file need to be edited for fitting the last changes with scheduling.

Maybe we should add a short component on the specific schedule WF

Updating the doc is still in TODO. But I don't want this file to delay the PR, so we can update it later in a separate PR.
I also want to include some debugging hints there.

avifenesh · 2024-09-01T15:50:56Z

.github/DEVELOPER.md

+
+Modify `<language>.yml` files to adjust language-specific steps.
+Update matrix files to change tested versions or environments.
+Adjust cron schedules in workflow files for different timing of scheduled runs.


for example here

avifenesh requested a review from a team as a code owner July 30, 2024 10:34

avifenesh temporarily deployed to AWS_ACTIONS July 30, 2024 10:34 — with GitHub Actions Inactive

avifenesh added enhancement New feature or request python node java issues and fixes related to the java client CI CI/CD related docs Documentation testing Platforms Platforms matter labels Jul 30, 2024

avifenesh added this to the node-GA milestone Jul 30, 2024

avifenesh linked an issue Jul 30, 2024 that may be closed by this pull request

Run full CI matrix on PR label "core functionality changes" #1961

Open

avifenesh requested a review from barshaul July 30, 2024 11:38

asafpamzn assigned avifenesh Aug 25, 2024

avifenesh and others added 4 commits August 30, 2024 19:39

limit pr run to ubuntu latest X first and last version supported, add…

ca54433

…ed schedule and label runs Signed-off-by: avifenesh <[email protected]>

limit CI

6e805af

Signed-off-by: avifenesh <[email protected]>

Address PR comments and update CI jobs.

77c6a70

Signed-off-by: Yury-Fridlyand <[email protected]>

Prettier.

8de966b

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand force-pushed the CI/TrrigerByLabel branch from 37e5b62 to 8de966b Compare August 31, 2024 02:48

Yury-Fridlyand had a problem deploying to AWS_ACTIONS August 31, 2024 02:48 — with GitHub Actions Error

Fix cron schedule.

e8a9fae

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand requested a deployment to AWS_ACTIONS August 31, 2024 02:53 — with GitHub Actions Waiting

avifenesh commented Sep 1, 2024

View reviewed changes

avifenesh mentioned this pull request Sep 2, 2024

Test different npm versions #2035

Open

avifenesh added Release blocker OPS and removed CI CI/CD related docs Documentation testing Core changes Used to label a PR as PR with significant changes that should trigger a full matrix tests. labels Sep 2, 2024

avifenesh requested a review from barshaul September 2, 2024 09:31

avifenesh assigned Yury-Fridlyand and unassigned avifenesh Sep 2, 2024

ikolomi removed the Release blocker label Sep 11, 2024

ikolomi modified the milestones: 1.1, 1.2 Sep 15, 2024

Yury-Fridlyand linked an issue Sep 19, 2024 that may be closed by this pull request

Align redis installation in CI for all OS and runners #781

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI - Minimal and full CI matrix impl #2051

CI - Minimal and full CI matrix impl #2051

avifenesh commented Jul 30, 2024 •

edited

Loading

avifenesh left a comment

avifenesh Sep 1, 2024

avifenesh Sep 1, 2024

avifenesh Sep 1, 2024

avifenesh Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024

MikeMwita Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024

avifenesh Sep 1, 2024

avifenesh Sep 1, 2024

avifenesh Sep 1, 2024

Yury-Fridlyand Sep 3, 2024

avifenesh Sep 1, 2024


		TODO: Add a description of the CI/CD workflow and its components.

		### Overview

CI - Minimal and full CI matrix impl #2051

Are you sure you want to change the base?

CI - Minimal and full CI matrix impl #2051

Conversation

avifenesh commented Jul 30, 2024 • edited Loading

avifenesh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avifenesh commented Jul 30, 2024 •

edited

Loading