Converge the warning-flags in Makefile and CMake builds #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Werror in CMake builds and enable -pedantic in Makefile. Signed-off-by: Björn Svensson <[email protected]>
Use the correct libevent2 type `evutil_socket_t` instead of `int` when implementing the libevent2 callback function in our tests. On Windows evutil_socket_t is an intptr_t (long long int). Defined in include/event2/event.h: typedef void(* event_callback_fn )(evutil_socket_t, short, void *) Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
|
Not sure if adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the same warnings in CMake as used in the Makefile (including
-Werror).Enable
-pedanticin Makefile, as in CMake, toissue all the warnings demanded by strict ISO C.Also fixes:
char*).evutil_socket_tinstead ofintwhen implementing the libevent2 callback function in our tests. On Windows evutil_socket_t is an intptr_t (long long int) which gives a warning (and error with gcc-14).(Required by Bump msys2/setup-msys2 from 2.23.0 to 2.24.1 #62)