windows: fix size of ssize_t
#57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code format checker as well as macOS and Centos build failures look unrelated |
bjosv
reviewed
Jul 30, 2024
Previously, `long long` was used unconditionally to define `ssize_t` on Windows. This meant it was always a 64-bit value. However, typically the size type is a 32-bit value on 32-bit machines and 64-bit value on 64-bit machines. This didn't cause any issues until it was used on 32-bit Windows build of `libvalkey-py`. CPython defines the `ssize_t` type as well as `libvalkey`, but it defines the size to be 32 bit on 32 bit machines which caused a compilation error. This commit changes the typedef to be `SSIZE_T` on Windows. Hence, it will be aligned with everything else. Signed-off-by: Mikhail Koviazin <[email protected]>
mkmkme
force-pushed
the
mkmkme/windows-ssize-t-size
branch
from
838d51a
to
892226c
Compare
bjosv
approved these changes
Jul 31, 2024
|
I don't think I have merge rights. If you think it's good to go, please merge so I can update it in libvalkey-py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
long longwas used unconditionally to definessize_ton Windows. This meant it was always a 64-bit value. However, typically the size type is a 32-bit value on 32-bit machines and 64-bit value on 64-bit machines.This didn't cause any issues until it was used on 32-bit Windows build of
libvalkey-py. CPython defines thessize_ttype as well aslibvalkey, but it defines the size to be 32 bit on 32 bit machines which caused a compilation error.This commit changes the typedef to be
SSIZE_Ton Windows. Hence, it will be aligned with everything else.