Fixing bugs from pr41 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:valeriupredoi/bgcval2 into improving_the_timeseries_variables_interface
valeriupredoi
approved these changes
Aug 16, 2022
| # 'convert': ukp.NoChange, | ||
| # 'units': 'pH', | ||
| # } | ||
| # else: |
There was a problem hiding this comment.
pls remove commented out code
There was a problem hiding this comment.
This whole section is in the 4000 lines that are scheduled to be deleted over the next few PRs. I'll remove it then!
There was a problem hiding this comment.
the more you remove (obv if needs to be removed) the less spaghetti the code becomes so your next PR will be cleaner to solve :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes a couple bugs introduced in PR 41, when the
analysisSuitevariable was renamedsuitesinanalysis_timeseries.py.